Improve readability when printing type of classes in error messages #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ijnek <[email protected]>
fujitatomoya
approved these changes
Jun 16, 2025
Contributor
|
Pulls: #469
|
ahcorde
approved these changes
Jun 16, 2025
Contributor
|
https://github.com/Mergifyio backport kilted jazzy humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
Signed-off-by: ijnek <[email protected]> (cherry picked from commit 9c5f6a7)
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
Signed-off-by: ijnek <[email protected]> (cherry picked from commit 9c5f6a7)
This was referenced Jun 17, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
Signed-off-by: ijnek <[email protected]> (cherry picked from commit 9c5f6a7) # Conflicts: # launch_ros/launch_ros/utilities/evaluate_parameters.py
ahcorde
pushed a commit
that referenced
this pull request
Jun 19, 2025
(cherry picked from commit 9c5f6a7) Signed-off-by: ijnek <[email protected]> Co-authored-by: Kenji Brameld <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Jun 20, 2025
(cherry picked from commit 9c5f6a7) Signed-off-by: ijnek <[email protected]> Co-authored-by: Kenji Brameld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to ros2/launch#887, in a few places, error messages printed types in a verbose format like '<class 'str'>'. This PR simplifies that by displaying just the type name (e.g. 'str').
Did you use Generative AI?
No